Removed unnecessary initializations when setting Tx or Rx mode. #20
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The same initialization of settings and pins is done during Init(). The change causes an significant speed improvement when switching between Tx and Rx modes rapidly. According to figure 13 (state diagram) in C1101 manual, it is allowed to go directly to Tx and Rx from either Idle, Tx or Rx mode.
|
Hi there, Thank you for the suggestion for improvement. I have tested everything and will take it into account in the next update. I noticed with arduino nano that with this method the sck pin stays high (onboard led lights up permanently). so in the end I still have digitalWrite (SCK_PIN, LOW); added. |
|
MR can be closed as changes were implemented in SmartRC-CC1101-Driver-Lib_V2.3 release. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The same initialization of settings and pins is done during Init(). The change causes
an significant speed improvement when switching between Tx and Rx modes rapidly.
According to figure 13 (state diagram) in C1101 manual, it is allowed to go
directly to Tx and Rx from either Idle, Tx or Rx mode.
SetRx/Tx(float mhz) functions have not been tested, as I don't have any equipment that works on frequencies different than 433.92MHz.